mirror / dolphin-emu

ARCHIVED Moved to *dolphin-emu/dolphin*
https://github.com/dolphin-emu/dolphin
14 stars 14 forks source link

Making state lzop compatible #33

Open john-peterson opened 11 years ago

john-peterson commented 11 years ago

Making state lzop compatible

Problem

The states aren't lzop compatible

This is a problem because they can't be extracted

lzop --info RSPE01.s08
lzop: rspe01.s08: not a lzop file

Inspecting the state is benecifial f.e. when creating binary patches

Solution

Changing the code

static bool g_use_compression = true

Making the state lzop compatible because

This patch shouldn't be merged until these changes are made

Save the state header values in the lzop header

[03:07] @Sonicadvance1 JPeterson, Pull #33, why make the states lzop capable?

The answer is in the topic "Problem"

[03:22] @Sonicadvance1 JPeterson, Let me be more clear about the issue of making the save states lzop capable. Why do we care to allow people to extract our savestates?

The benefit with extracting a state is in the topic "Problem"

[03:23] @Jasper TAS tools? [03:23] @Sonicadvance1 TAS tools? [03:24] @Sonicadvance1 If it is a "tool" or program, then it could just extract our savestate the same way we already do

[03:24] @RachelB Sonicadvance1: dolphin is the tool

[03:25] @Sonicadvance1 RachelB, That is the expected answer right. So I want a better reason for lzop support

[03:26] @RachelB Sonicadvance1: because it makes examining or editing a save state easier