add: support for named value #15

mirsaeedi / dotnet-apim

dotnet-apim is a cross-platform dotnet tool which streamlines the CI/CD process of deploying APIs into Azure API Management

MIT License

30 stars 10 forks source link

add: support for named value #15 #16

Closed mirsaeedi closed 3 years ago

mirsaeedi commented 3 years ago

resolves #15

mirsaeedi commented 3 years ago

@andrewdmoreno would you mind to take a look?

andrewdmoreno commented 3 years ago

@mirsaeedi Sure I will take a look.

andrewdmoreno commented 3 years ago

LGTM. I still think that it would be nice to somehow have the capability when defining a secret named value to pass the secret value as an arm parameter. Perhaps that can be a future enhancement. ;)

I'd have to be more familiar with the code base to know how big of an effort that is.

mirsaeedi commented 3 years ago

@andrewdmoreno We can have in future for sure. Your contribution is much appreciated. We can work on it together if you will.