search

mirsaeedi / dotnet-apim

dotnet-apim is a cross-platform dotnet tool which streamlines the CI/CD process of deploying APIs into Azure API Management
MIT License
30 stars 10 forks source link

Allow ServiceFabric backend clientCertificateId reference #43

Closed levimatheri closed 2 years ago

levimatheri commented 2 years ago

@mirsaeedi One more haha... We have a need to reference the Service Fabric client certificate using clientCertificateId. This property is available in API version 2021-08-01.

The value in the generated ARM template would be a resourceId, i.e. 

"serviceFabricCluster": {
    "clientCertificateId": "[resourceId('Microsoft.ApiManagement/service/certificates', parameters('ApimServiceName'), '[clientcertId]')]",
     ...
}

I have working code I can submit a PR for, but we'd need to update the API schema version. Lemme know your thoughts :)

mirsaeedi commented 2 years ago

Hey! Please send out the PR. I've already bump up the version. Please get the latest changes.

levimatheri commented 2 years ago

Okay, will submit a PR soon