search

miru-project / miru-app

🎉 A versatile application that is free, open-source, and supports extension sources for videos, comics, and novels, available on Android, Windows, and Web platforms.
https://miru.js.org
GNU Affero General Public License v3.0
3.43k stars 147 forks source link

Improve the video player #231

Open ferivoq opened 5 months ago

ferivoq commented 5 months ago

Describe your suggested feature

Hey! I really like the app cause I use win 11 and an android so I like that it both fluent ui and m3. I would use the app cause it has a very good ui and I made my own extension for it, but the video player is very bad designed and not themed around neither fluent ui or m3. I would love to see that improving. And I don't know if it's the problem with my extension or not but I can't seem to change the quality of the anime in the player. I would love to see these improved cause I really like the app but this is a big con for me. Thanks

Acknowledgements

ferivoq commented 5 months ago

Screenshot_20240227-215701 For example this is the player of an app named Dantotsu. I would love to see something like this

bachig26 commented 4 months ago

@ferivoq if you haven't tried the dev build which has a new video player, which is kind of better than previous one. you can get it from the actions tab and download the artifacts to the respective device you want.

and the quality of a content is 100% based on the source and the extension. if the developer of a extension made it to have multiple qualities from the source then you can see all and choose your desired one. if not, then it's just the one. in the new video player, you can see the current quality/resolution of the content in the bottom-left side, click them to view if there's any other options available to change it.

ferivoq commented 4 months ago

Wow sounds cool thanks for your reply I will check the video player and will give feedback if needed if that's okay.

ferivoq commented 4 months ago

Hey! I checked the new player and it looks great. Nice job. The only thing I could say is that the current place of back, pause and forward buttons is not the best at the bottom left. If they were in the center of the screen it would be much better for UX. For example on YouTube they're in the middle of the screen and people remember it. But putting it into the left bottom is not the best cause the buttons are very small so there is a chance that you mistakenly click on the forward button but you wanted to pause. I hope that atleast there will be a setting to do so.

bachig26 commented 4 months ago

you can ask the dev's here in GitHub or at Telegram and maybe open a issue with better info, so they can understand it. When you open a new issue, please close this one.