mirukana / mirage

A fancy, customizable, keyboard-operable Qt/QML & Python Matrix chat client for encrypted and decentralized communication.
GNU Lesser General Public License v3.0
411 stars 40 forks source link

Notification rules for unencrypted messages aren't being followed #244

Open whatapleasantsurprise opened 3 years ago

whatapleasantsurprise commented 3 years ago

Description

Adding a notification rule for an unencrypted room (either a group or a 1-to-1 conversation) isn't being fully followed by mirage.

Your environment

Steps to reproduce

Suppose we have a room, adding a rule for this room, either in the Room rules, High priority general rules or Low priority general rules, will only affect the Mark as unread and Highlight, mark as important toggles. The Show notification bubble and Play sound will fallback to the options of the Low priority general rules category they belong to (1-to-1 or groups), regardless of the options set in higher level configurations.

For encrypted messages, I experience the correct behavior, i.e. higher level rules take precedence over lower level ones and they do not get mixed together.

I tried reproducing this a couple of times (4 rooms), and it always resulted in the above behavior.

MRAAGH commented 2 years ago

Fixed by https://github.com/poljar/matrix-nio/pull/293