mirulumam / dabr

Automatically exported from code.google.com/p/dabr
0 stars 0 forks source link

Twitter's new style retweet page doesn't working correctly with Snowflake ids #154

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What are the steps to trigger the problem?
1)find any tweet that id does not end with '..000'
2)try to retweet it using twitter's new style retweet

What happened?
now twitter return 404, since dabr posted wrong id.

Fix method:
common/twitter.php,line 1274
change 
'twitter-retweet/{$status->id}'
to
'twitter-retweet/{$status->id_str}'

Related:
http://groups.google.com/group/twitter-development-talk/browse_thread/thread/6a1
6efa375532182?pli=1

Original issue reported on code.google.com by Manyous...@gmail.com on 11 Nov 2010 at 7:13

GoogleCodeExporter commented 9 years ago
PS: I think this problem only occur on hosts using poor JSON decoder.

Original comment by Manyous...@gmail.com on 11 Nov 2010 at 7:21

GoogleCodeExporter commented 9 years ago
This is a 32 bit PHP problem that is already fixed in r355.

Original comment by david.carrington on 11 Nov 2010 at 8:02

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
no this is still a bug and a json problem in r359 since you haven't change line 
836&837 of twitter.php or json_decode in twitter_process

836     $request = API_URL."statuses/show/{$id}.json";
837     $tl = twitter_process($request);

and since you simply use json_decode($response) in twitter_process as well as 
no special dealing with tweet id, I can't see how you fix it.

Original comment by Manyous...@gmail.com on 11 Nov 2010 at 1:09

GoogleCodeExporter commented 9 years ago
Very true. But the fix should be a change around line 837 to ensure that the 
decoded JSON goes through twitter_standard_timeline() like all other JSON.

Original comment by david.carrington on 11 Nov 2010 at 1:39

GoogleCodeExporter commented 9 years ago
Can (redundantly?) confirm that this is still a bug in r359.

My server's specs (beware, old system):
* Linux 2.6.9-023stab048.6-enterprise i686 GNU/Linux
* PHP 5.1.2

The fix proposed by Manyoushen works (at least until a "better" fix comes 
around), thank you.

Original comment by aker...@freenet.de on 30 Nov 2010 at 11:32

GoogleCodeExporter commented 9 years ago

Original comment by david.carrington on 15 Dec 2010 at 9:26

GoogleCodeExporter commented 9 years ago
Issue 159 has been merged into this issue.

Original comment by david.carrington on 29 Mar 2011 at 3:51