feat: Add docs for query parsing & validation caching

mirumee / ariadne-website

The code that powers Ariadne website

https://ariadnegraphql.org

BSD 3-Clause "New" or "Revised" License

23 stars 37 forks source link

Closed lukapeschke closed 5 months ago

lukapeschke commented 11 months ago

lukapeschke commented 10 months ago

@rafalp does the updated version LGTY ?

rafalp commented 10 months ago

Hello, apologies - I've forgotten about this PR completely 😅

The code looks good but I have two nitpicks:

Documents title should mention caching for both query parsing and validation (but I have no suggestion for this ATM)
Initial paragraph should explain that enabling cache may improve server's performance.

lukapeschke commented 10 months ago

@rafalp no problem :smile: let me know what you think about the latest version

lukapeschke commented 5 months ago

@rafalp can we merge or close this ? I'm trying to get on top of all my open PRs :sweat_smile:

rafalp commented 5 months ago

@lukapeschke I'm happy to merge this documentation now and improve it later myself. Thanks!

lukapeschke commented 5 months ago

Great, thank you!