search

mirumee / django-prices

Django fields for the prices module
158 stars 52 forks source link

Add contribute_to_class method on PriceField #26

Closed artursmet closed 8 years ago

artursmet commented 8 years ago

In version 0.4.2 we've changed base class for PriceField. DecimalField doesn't set Creator by default, so it breaks logic in some cases.

codecov-io commented 8 years ago

Current coverage is 80.10%

Merging #26 into master will increase coverage by +8.79% as of da83af7

@@            master    #26   diff @@
=====================================
  Files            5      6     +1
  Stmts          122    186    +64
  Branches        17     18     +1
  Methods          0      0       
=====================================
+ Hit             87    149    +62
- Partial          5      6     +1
- Missed          30     31     +1

Review entire Coverage Diff as of da83af7

Powered by Codecov. Updated on successful CI builds.

bogdal commented 8 years ago

In my opinion we should move django.setup() and TestModel class to the top of the module.

patrys commented 8 years ago

Could we make it a module-level fixture instead? I really don't like the idea of test imports having serious side effects.