search

mirumee / legacy-views

A legacy fork of Saleor that contains the old storefront and dashboard code
Other
14 stars 14 forks source link

Fix delete data from user detail when password change #1

Closed IKarbowiak closed 4 years ago

IKarbowiak commented 4 years ago

Don't delete user name data after password changing. Fixes https://github.com/mirumee/saleor/issues/5003

Pull Request Checklist

  1. [ ] Privileged views and APIs are guarded by proper permission checks.
  2. [ ] All visible strings are translated with proper context.
  3. [ ] All data-formatting is locale-aware (dates, numbers, and so on).
  4. [ ] Database queries are optimized and the number of queries is constant.
  5. [ ] Database migration files are up to date.
  6. [ ] The changes are tested.
  7. [ ] GraphQL schema and type definitions are up to date.
  8. [ ] Changes are mentioned in the changelog.
codecov[bot] commented 4 years ago

Codecov Report

Merging #1 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   91.19%   91.19%   +<.01%     
==========================================
  Files         351      351              
  Lines       21399    21403       +4     
  Branches     2042     2042              
==========================================
+ Hits        19514    19518       +4     
  Misses       1329     1329              
  Partials      556      556
Impacted Files Coverage Δ
saleor/account/views.py 81.81% <100%> (+0.68%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d06516...949b11d. Read the comment docs.