search

mirumee / prices

Python price handling for humans.
Other
268 stars 39 forks source link

Add PercentageDiscount #17

Closed artursmet closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 94.00%

Merging #17 into master will increase coverage by +0.41% as of 9a36832

@@            master    #17   diff @@
=====================================
  Files            1      1       
  Stmts          203    217    +14
  Branches        36     36       
  Methods          0      0       
=====================================
+ Hit            190    204    +14
  Partial          5      5       
  Missed           8      8

Review entire Coverage Diff as of 9a36832

Powered by Codecov. Updated on successful CI builds.

patrys commented 8 years ago

I'd like to rename FractionDiscount to FractionalDiscount.

Can we also test repr?

Also currently PercentageDiscount does not have any specific properties so it could be replaced by a function that returns a FractionalDiscount instance.

artursmet commented 8 years ago

@patrys Refactored, now percentage_discount is a function, instead of class