search

mirumee / prices

Python price handling for humans.
Other
268 stars 39 forks source link

Don't install typing if python version if >= 3.5 #35

Closed si14 closed 4 years ago

si14 commented 4 years ago

It breaks pip, see https://github.com/mbarkhau/pycalver/pull/148

codecov[bot] commented 4 years ago

Codecov Report

Merging #35 into master will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   99.39%   99.40%   +0.01%     
==========================================
  Files           7        8       +1     
  Lines         330      338       +8     
  Branches       54       54              
==========================================
+ Hits          328      336       +8     
  Misses          1        1              
  Partials        1        1
Impacted Files Coverage Δ
prices/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd74e1f...6b99049. Read the comment docs.

si14 commented 4 years ago

The build failure seems to be related to problems in master, not to the PR itself.

maarcingebala commented 4 years ago

Oh, this bug with typing happens in Saleor as well, it would be really useful to have these changes @patrys.