pkucmus
commented
2 years ago No idea why the 3.10 check is failing, it runs just fine locally:
~/Development/saleor-app-framework-python feature/fix_jinja_dep
saleor-app-DivDKMLI-py3.10 ❯ poetry run coverage erase
poetry run coverage run --source="saleor_app" -p -m pytest src/saleor_app
poetry run coverage combine
poetry run coverage report --fail-under=90
Test session starts (platform: linux, Python 3.10.4, pytest 6.2.5, pytest-sugar 0.9.5)
rootdir: /home/pkucmus/Development/saleor-app-framework-python, configfile: pyproject.toml
plugins: cov-2.12.1, mock-3.8.2, sugar-0.9.5, anyio-3.6.1, asyncio-0.19.0
asyncio: mode=auto
collecting ...
src/saleor_app/tests/test_app.py ✓✓ 7% ▊
src/saleor_app/tests/test_deps.py ✓✓✓✓✓✓✓✓✓✓✓✓ 50% █████
src/saleor_app/tests/test_endpoints.py ✓✓ 57% █████▊
src/saleor_app/tests/test_exception_handlers.py ✓✓ 64% ██████▌
src/saleor_app/tests/test_install.py ✓✓ 71% ███████▎
src/saleor_app/tests/saleor/test_client.py ✓✓✓✓✓✓✓✓ 100% ██████████
Results (0.81s):
28 passed
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7f3cb8b15150>
Combined data file .coverage.GUx.1744581.496046
Name Stmts Miss Cover
---------------------------------------------------------------------
src/saleor_app/__init__.py 0 0 100%
src/saleor_app/app.py 23 0 100%
src/saleor_app/deps.py 75 15 80%
src/saleor_app/endpoints.py 37 4 89%
src/saleor_app/errors.py 3 0 100%
src/saleor_app/install.py 29 5 83%
src/saleor_app/saleor/__init__.py 0 0 100%
src/saleor_app/saleor/client.py 26 0 100%
src/saleor_app/saleor/exceptions.py 11 0 100%
src/saleor_app/saleor/mutations.py 2 0 100%
src/saleor_app/saleor/utils.py 4 1 75%
src/saleor_app/schemas/__init__.py 0 0 100%
src/saleor_app/schemas/core.py 33 0 100%
src/saleor_app/schemas/exception_handlers.py 14 0 100%
src/saleor_app/schemas/handlers.py 118 0 100%
src/saleor_app/schemas/manifest.py 41 0 100%
src/saleor_app/schemas/utils.py 35 8 77%
src/saleor_app/schemas/webhook.py 33 0 100%
src/saleor_app/settings.py 10 0 100%
src/saleor_app/tests/__init__.py 0 0 100%
src/saleor_app/tests/conftest.py 42 1 98%
src/saleor_app/tests/test_app.py 14 0 100%
src/saleor_app/tests/test_deps.py 63 0 100%
src/saleor_app/tests/test_endpoints.py 27 0 100%
src/saleor_app/tests/test_exception_handlers.py 13 2 85%
src/saleor_app/tests/test_install.py 22 0 100%
src/saleor_app/webhook.py 34 7 79%
---------------------------------------------------------------------
TOTAL 709 43 94%
I did not have the time to investigate the course in full but it seems like maybe in an older pip version it was possible to specify deps like it was done before this change - kinda like you'd inject SQL... In the end it's broken now. Poetry asks pip to install that
Jinja2 = "jinja2 >=2.11.2,<4.0.0"and pip errors out, this PR is to address that.