search

miryamW / LeetCode-server

A full-stack system emulating Leetcode.com.
1 stars 0 forks source link

remove hardcoded strings #1

Open itai-gendler opened 2 days ago

itai-gendler commented 2 days ago

https://github.com/miryamW/LeetCode-server/blob/47281d4e4ca8f7fc574bad25aed3e5720177435a/services/question.service.go#L26C1-L27C1

please remove hardcoded strings like database endpoint. this should be a dynamic value because it can change between production and local development.

best approach is to use environment variables and put local endpoint as default. you should have some config component that will take care of this and will verify that all required inputs for the server properly exists. you can also use .dotenv in addition

miryamW commented 2 days ago

OK. I will do it. Does the rest of the code meet the requirements? Thank you!

itai-gendler commented 2 days ago

i didn't go over everything deeply because you are still working on it. i suggest once you have some working scenarios, lets zoom and then we can go over everything together. it doesn't have to be completed, even if it's just a few working scenarios. better in coming days so you have enough time to handle all comments

looks like you are moving fast so that's good

On Mon, Nov 11, 2024 at 1:22 PM Miryam Weil @.***> wrote:

OK. I will do it. Does the rest of the code meet the requirements? Thank you!

— Reply to this email directly, view it on GitHub https://github.com/miryamW/LeetCode-server/issues/1#issuecomment-2467930882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2L4YOBIROQCKP4ZVWCDCL2ACHN3AVCNFSM6AAAAABRRPLEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXHEZTAOBYGI . You are receiving this because you authored the thread.Message ID: @.***>

itai-gendler commented 2 days ago

with ui elements as well

On Mon, Nov 11, 2024 at 2:31 PM Itai Gendler @.***> wrote:

i didn't go over everything deeply because you are still working on it. i suggest once you have some working scenarios, lets zoom and then we can go over everything together. it doesn't have to be completed, even if it's just a few working scenarios. better in coming days so you have enough time to handle all comments

looks like you are moving fast so that's good

On Mon, Nov 11, 2024 at 1:22 PM Miryam Weil @.***> wrote:

OK. I will do it. Does the rest of the code meet the requirements? Thank you!

— Reply to this email directly, view it on GitHub https://github.com/miryamW/LeetCode-server/issues/1#issuecomment-2467930882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2L4YOBIROQCKP4ZVWCDCL2ACHN3AVCNFSM6AAAAABRRPLEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXHEZTAOBYGI . You are receiving this because you authored the thread.Message ID: @.***>

miryamW commented 15 hours ago

Could we possibly have a Zoom meeting today? I feel I've made progress and would like to discuss the next steps.

itai-gendler commented 15 hours ago

Yes of course. Lets schedule for 15:00?

It will be best if you can show me a demo of it

On Wed, 13 Nov 2024, 11:49 Miryam Weil, @.***> wrote:

Could we possibly have a Zoom meeting today? I feel I've made progress and would like to discuss the next steps.

— Reply to this email directly, view it on GitHub https://github.com/miryamW/LeetCode-server/issues/1#issuecomment-2473020713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2L4YM7LMNOTLWEK3TY2TD2AMOEFAVCNFSM6AAAAABRRPLEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZTGAZDANZRGM . You are receiving this because you authored the thread.Message ID: @.***>

itai-gendler commented 13 hours ago

Hey. I cant do it today. Lets do it tomorrow morning 09:00?

On Wed, 13 Nov 2024, 12:12 Itai Gendler, @.***> wrote:

Yes of course. Lets schedule for 15:00?

It will be best if you can show me a demo of it

On Wed, 13 Nov 2024, 11:49 Miryam Weil, @.***> wrote:

Could we possibly have a Zoom meeting today? I feel I've made progress and would like to discuss the next steps.

— Reply to this email directly, view it on GitHub https://github.com/miryamW/LeetCode-server/issues/1#issuecomment-2473020713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD2L4YM7LMNOTLWEK3TY2TD2AMOEFAVCNFSM6AAAAABRRPLEI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZTGAZDANZRGM . You are receiving this because you authored the thread.Message ID: @.***>

miryamW commented 12 hours ago

OK