Update Kotlin to 2.0.0 - Githubissues

mirzemehdi / KMPAuth

Kotlin Multiplatform Authentication Library targetting android and iOS

https://mirzemehdi.com/KMPAuth/

Apache License 2.0

178 stars 16 forks source link

Update Kotlin to 2.0.0 #23

Closed shoheikawano closed 4 months ago

shoheikawano commented 4 months ago

What's changed?

I have updated Kotlin version from 1.9.23 to 2.0.0 and some other libraries to the latest version so that it works with the project with Kotlin 2.0 dependency.

Why is this change necessary?

I faced the issue where my app crashes after I started using the library with Kotlin 2.0.0 in my project.

What has been checked?

I have checked if the sample project can be build successfully.
I have checked that when clicking the Google Auth button it shows the dialog to let users choose their account to sign in.

shoheikawano commented 4 months ago

hopefully it closes this issue: https://github.com/mirzemehdi/KMPAuth/issues/24

mirzemehdi commented 4 months ago

Thank you very much for this implementation @shoheikawano. Overall, it looks good to me. But what is the reason to add

alias(libs.plugins.composeCompiler) in gradle files? Is this required thing now?

shoheikawano commented 4 months ago

Hi @mirzemehdi thanks for checking.

what is the reason to add alias(libs.plugins.composeCompiler) in gradle files? Is this required thing now?

Yes it is now required otherwise compilations fail

ref: https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-compiler.html#migrating-a-compose-multiplatform-project

shoheikawano commented 4 months ago

Thanks for the review :)