mirzemehdi / KMPAuth

Kotlin Multiplatform Authentication Library targetting android and iOS
https://mirzemehdi.com/KMPAuth/
Apache License 2.0
231 stars 19 forks source link

Samsung Galaxy S23 Ultra Bug #45

Closed tarikkeskin closed 1 month ago

tarikkeskin commented 2 months ago

Greetings. When i try to google sign in , i can't get any response. Code stuck in this signIn() method.

val googleUser = googleAuthUiProvider.signIn()

I ve tried these versions '2.0.0' , '2.1.0-alpha02' and '1.4.0', all the same, could you help me ?

mirzemehdi commented 2 months ago

@tarikkeskin any logs that you can attach?.

mirzemehdi commented 2 months ago

Closing this issue due to inactivity. If this is still an issue or need a help, please feel free to reopen the issue and provide additional context or updates. Thank you.

adden00 commented 1 month ago

@tarikkeskin any logs that you can attach?.

same problem. sign button call dialog to select account, and then googleAuthUiProvider.signIn() returns null, so onFirebaseResult return Result.fail

image

inside Application onCreate call GoogleAuthProvider.create(credentials = GoogleAuthCredentials(serverId = WEB_CLIENT_ID)) with client Id from googleServices.json

adden00 commented 1 month ago

tested on OnePlus 9 and Samsung galaxy s21. both with sdk 34 (android 14), with google services 4.4.0 and 4.4.2

adden00 commented 1 month ago

in your travel app also don`t work :) telegram-cloud-photo-size-2-5188178386441332568-y

mirzemehdi commented 1 month ago

@adden00 Can you please search in the logs "GoogleAuthUiProvider" and let me know what it prints

adden00 commented 1 month ago

in my attempt to use library, it shows: GoogleAuthUiProvider error: During begin sign in, failure response from one tap: 10: [28444] Developer console is not set up correctly.

when try to authorize in your app, it shows: GoogleAuthUiProvider error: Your device doesn't support credential manager

seems that in my app the problem is in clientId or settings in google developer console... thanks for directing where to search a problem :)

mirzemehdi commented 1 month ago

Thanks for this @adden00 attaching related issue here:

https://github.com/android/identity-samples/issues/70

mirzemehdi commented 1 month ago

Looks like some android 14 issue: https://github.com/android/identity-samples/issues/70#issuecomment-2394814465

not sure if it is helpful, in the issue it is commented that "Hi this is due to some OEMs not enabling passkeys on their devices. Could you please update your app to sue 1.2.1, we ahve added a fix there. Let us know if you still see the error, feel free to reopen this." (https://github.com/android/identity-samples/issues/70#issuecomment-2003255942)

adden00 commented 1 month ago

Ok, I will try it, thanks!

adden00 commented 1 month ago

In my case the problem was in firebase project settings :) I forgot to add the SHA-1 fingerprint to the Android app settings in the Firebase console. And when I did, and installed the signed APK, it started working well even on Android 14

adden00 commented 1 month ago

thanks for this lib, and for quick answering!