search

mirzemehdi / KMPAuth

Kotlin Multiplatform Authentication Library targetting android and iOS
https://mirzemehdi.com/KMPAuth/
Apache License 2.0
231 stars 19 forks source link

[Nice to have] Apple SignIn Button with mode BlackWithOutline #64

Closed erickvelasco11 closed 1 week ago

erickvelasco11 commented 3 weeks ago

Hi Thanks for all your work here, this have been really helpfully in our work.

Just a nice to have. Implement the BlackWithOutline. This for keep the style of the buttons in dark mode.

i.e. This is my login page with light mode white

But this is my login page in dark mode. The apple button is like a bulb on and the mode "black" is worst in dark mode black

However, this is not impacting the functionality.

Thanks again for your work

mirzemehdi commented 1 week ago

@erickvelasco11 thanks for suggestion but official Apple guideline suggest only 3 modes of Button:

White, White with Outline, Black

All of these three are provided by library.

https://developer.apple.com/design/human-interface-guidelines/sign-in-with-apple#sign-in-with-apple-buttons

Closing the issue