search

mirzemehdi / KMPAuth

Kotlin Multiplatform Authentication Library targetting android and iOS
https://mirzemehdi.com/KMPAuth/
Apache License 2.0
231 stars 19 forks source link

Add email to GoogleUser #65

Closed doolle89 closed 1 week ago

doolle89 commented 2 weeks ago

Is it ok to retrieve email directly from idToken on client device? As pointed out in this issue email is sometimes omitted from idToken but it seems it is mandatory field in GoogleIdTokenCredential so we can get it from there

doolle89 commented 2 weeks ago

I updated points from the review... Just please test it if you can before merging, I can't test sample app, most probably because my keystore fingerprint is not matching the one in GPC

mirzemehdi commented 2 weeks ago

Thank you @doolle89 for changes. After testing I'll merge it

mirzemehdi commented 1 week ago

Thanks again @doolle89 for this, just tested, and published new release. This will be available in 2.3.0-beta01 version