misakuo / JsonModelGenerator

Converting JSON string to Java Class in IDEA / Android Studio
https://plugins.jetbrains.com/plugin/8062
MIT License
58 stars 17 forks source link

Bug fix #6

Closed zzt93 closed 7 years ago

zzt93 commented 7 years ago

Fix the bug when used in 2016.3, click path choosing caused NPE. Your original code set tool frame invisible when choosing path, which make it fail to create dialog (the logic of DialogWrapperPeerImpl.java require its father component, i.e. too frame, to be visible). So there exists two ways to solve it:

I chose the second one to make it consistent with your original behavior. I only tested on latest version of intellij (2016.1, 2016.3). Is there easy way to test on multiple versions?

misakuo commented 7 years ago

Is all IDE contains the class WindowManagerEx ?

misakuo commented 7 years ago

Tested on Android Studio 1.5.1 and it works well. By the way, replace WindowManagerEx with WindowManager could be better?

misakuo commented 7 years ago

I have not maintained this plugin for a long time, maybe you can add some of the long-awaited features for the user, such as generate getter and setter, custom field names, and more……

zzt93 commented 7 years ago

I am not sure whether replacing WindowManagerEx with WindowManager could be better, I just saw other part of idea source using WindowManagerEx to generate dialog so I mimic that code.

I may consider adding some of them if I have time.

zzt93 commented 7 years ago

May I refactor your repo structure? like removing those versions of zip?

misakuo commented 7 years ago

Method findVisibleFrame () is defined in classWindowManager, the WindowManagerEx has extended WindowManager

misakuo commented 7 years ago

Sure, you can do anything you want in your repo and pull request to here

misakuo commented 7 years ago

link to #7