search

mischa78 / boxroom

Boxroom is a Rails application that aims to be a simple interface for managing and sharing files in a web browser. It lets users create folders and upload, download and share files. Admins can manage users, groups and permissions.
http://boxroomapp.com/
MIT License
318 stars 103 forks source link

Tagging for files and folders + search #46

Open Yardboy opened 9 years ago

Yardboy commented 9 years ago

Hiya -

I implemented a tagging feature in my own version of boxroom a couple months ago, along with a search for files/folders on tags. I took the time today to migrate it into a fork of your current branch.

Demo: http://screencast.com/t/RmG3wChW7v6

I used the following when writing this:

Not sure how you feel about additional gems/js libraries.

Would you like a pull request for this feature? I don't have a full battery of tests written, yet, and there are a couple of things to cleanup, but I'll be happy to send it along once I get that done.

mischa78 commented 9 years ago

I like what I see in your screencast! Did you make sure the permissions stuff was taken into account properly? Wouldn't want files/folders to show up in search results that users are not supposed to see.

Yardboy commented 9 years ago

Yeah, that's part of the "cleanup" I still need to do. My client's installation doesn't make use of the permissions system - all their users are internal and have access to everything. So, I haven't taken the time to build that out, unless you like it enough to take a pull request. If it will make it into app, then it's worth the time.

Also working on a "download folder as a zip file" feature.

c. On Nov 21, 2014 6:50 PM, "Mischa Berger" notifications@github.com wrote:

I like what I see in your screencast! Did you make sure the permissions stuff was taken into account properly? Wouldn't want files/folders to show up in search results that users are not supposed to see.

— Reply to this email directly or view it on GitHub https://github.com/mischa78/boxroom/issues/46#issuecomment-64056272.

mischa78 commented 9 years ago

Hi, sorry for the late reply. I was away on vacation for a few days. It looks great, so I will definitely accept your pull request.

It looks like acts-as-taggable-on is actively maintained, so I have no problem adding that gem to the app. Is there a gem for sugarjs? I'd to be able to update to new versions of the library by doing bundle update.

Yardboy commented 9 years ago

Hiya -

No worries. "Vacation" - I'm not sure I understand this word - what does it mean. :)

SugarJS is just an included javascript file. I'm personally not a fan of using a gem just to include a js file. There is a gem out there but it does not look actively maintained. I use it by default everywhere, but in this case I don't think I've actually used more than one or two of the features

For future, I would recommend having a look at it though, it's a wonderful little add on for js work.

I've got permissions done and just need to wrap up the tests. Probably another week or two and then I'll get it to you.

c.

On Sat, Nov 29, 2014 at 9:20 AM, Mischa Berger notifications@github.com wrote:

Hi, sorry for the late reply. I was away on vacation for a few days. It looks great, so I will definitely accept your pull request.

It looks like acts-as-taggable-on is actively maintained, so I have no problem adding that gem to the app. Is there a gem for sugarjs? I'd to be able to update to new versions of the library by doing bundle update.

— Reply to this email directly or view it on GitHub https://github.com/mischa78/boxroom/issues/46#issuecomment-64953283.

brentdodell commented 9 years ago

Any update on this?

Thanks!

mischa78 commented 9 years ago

@Yardboy, would you still be willing to send a pull request for this? It's OK to use SugarJS.