Second, is there a reason that you override some defaults of the generatesw config (skipWaiting & clientsClaim)?
I was expecting that the same default configuration was used by your code.
Nothing big though as it can be easily overriden in the package.json.
But IMO it should stick to the workbox default or at least mention any deviation from it in the README.md :)
In the first case, the update should be made in a major release…
In all cases I can make a PR if needed.
mischnic
commented
5 years ago
Hi,
first thank you for this great plugin!
Second, is there a reason that you override some defaults of the generatesw config (
skipWaiting&clientsClaim)?I was expecting that the same default configuration was used by your code. Nothing big though as it can be easily overriden in the
package.json.But IMO it should stick to the workbox default or at least mention any deviation from it in the README.md :) In the first case, the update should be made in a major release… In all cases I can make a PR if needed.
Anyway, thanks again for making/maintaining this!