search

mischnic / parcel-plugin-sw-cache

📦👷 Parcel plugin for caching using a service worker
https://npm.im/parcel-plugin-sw-cache
MIT License
47 stars 6 forks source link

Fix getConfigForEntry #21

Closed likr closed 5 years ago

likr commented 5 years ago

In version 0.3, I got the following warning and sw.js was not generated.

$ parcel build src/index.html

⚠️  Plugin parcel-plugin-sw-cache failed to initialize: Error: Cannot find module '/Users/likr/src/wam-simulator/src/package.json'
Require stack:
- /Users/likr/src/wam-simulator/node_modules/parcel-plugin-sw-cache/index.js
- /Users/likr/src/wam-simulator/node_modules/parcel-bundler/src/utils/localRequire.js
- /Users/likr/src/wam-simulator/node_modules/parcel-bundler/src/Bundler.js
- /Users/likr/src/wam-simulator/node_modules/parcel-bundler/index.js
- /Users/likr/src/wam-simulator/node_modules/parcel-bundler/src/cli.js
- /Users/likr/src/wam-simulator/node_modules/parcel-bundler/bin/cli.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:623:15)
    at Function.Module._load (internal/modules/cjs/loader.js:527:27)
    at Module.require (internal/modules/cjs/loader.js:681:19)
    at require (/Users/likr/src/wam-simulator/node_modules/v8-compile-cache/v8-compile-cache.js:161:20)
    at getConfigForEntry (/Users/likr/src/wam-simulator/node_modules/parcel-plugin-sw-cache/index.js:38:9)
    at module.exports (/Users/likr/src/wam-simulator/node_modules/parcel-plugin-sw-cache/index.js:48:18)
    at Bundler.loadPlugins (/Users/likr/src/wam-simulator/node_modules/parcel-bundler/src/Bundler.js:219:17)
    at async Bundler.start (/Users/likr/src/wam-simulator/node_modules/parcel-bundler/src/Bundler.js:375:5)
    at async Bundler.bundle (/Users/likr/src/wam-simulator/node_modules/parcel-bundler/src/Bundler.js:252:7)

This patch solves the error and adds a test.

mischnic commented 5 years ago

Thanks!

mischnic commented 5 years ago

Released as v0.3.1