search

mischov / meeseeks_html5ever

Meeseeks-specific NIF binding of html5ever using Rustler.
Apache License 2.0
10 stars 14 forks source link

Compilation error with ERTS 9.2 #9

Closed mischov closed 6 years ago

mischov commented 6 years ago

Attempts to compile with ERTS 9.2 yield following error

error: failed to run custom build command for `erlang_nif-sys v0.6.2`

Unable to compile with ERTS 9.2, due to issue with Rustler and erlang_nif-sys. See: https://github.com/hansihe/rustler/issues/115

Awaiting release of Rustler containing merged fix.

OvermindDL1 commented 6 years ago

Same error, one of my bots is now dead because the server was updated to Elixir 1.6 with ERTS 9.2 because some other things required some functionality from it. :sob:

Rustler says it was already updated 12 days 'before' this issue was opened? :-) Maybe bind to a github release with the fix for now? ^.^

OvermindDL1 commented 6 years ago

Using the github (with subpath) for the mix and changing the Cargo.toml to use the github repo got it working (maybe there is a new version there?), so it does work, just they really need to release it, however a workaround is available for now? >.>

OvermindDL1 commented 6 years ago

And an update has finally been released whoo!

Can meeseeks update it's Cargo.toml file to version rustler = "^0.16.0" now? :-)

I edited my local copy (but my CI is still failing) and it seems to work fine. :-)

OvermindDL1 commented 6 years ago

Also update the mix.exs file to version 0.16 as well for rustler (they bumped the mix version to match the rust version)

mischov commented 6 years ago

Fixed in v0.8.1.

OvermindDL1 commented 6 years ago

Whooo! Thanks much! I can remove my hack now. :-)