miscreant / xstream

Public key encryption system combining X25519 ephemeral Diffie-Hellman key exchange and STREAM-based symmetric cryptography
Apache License 2.0
25 stars 1 forks source link

Use ciphersuite strings to select ciphers? #11

Open tarcieri opened 6 years ago

tarcieri commented 6 years ago

The test vectors presently use the following ciphersuite strings:

However, none of the existing XSTREAM implementations accept these as arguments, but instead take an AES-SIV versus AES-PMAC-SIV string which is passed directly to Miscreant (where applicable).

For the Rust implementation in particular, it would be nice to have object safe traits for STREAM which allow us to use either STREAM or XSTREAM via a trait object, and in particular to select the stream encryptor type to use based on a string.

xorxornop commented 6 years ago

In particular, these constructions could very well be made through a series of Decorator-pattern traits/impls. Stringly-typed parameters in Rust is just.... wrong!

tarcieri commented 6 years ago

Selection of which cipher to use can often come from a string parameter, such as a command-line option or data read from a file.

I love types too, but there's a point where you have to interface with a user...

eternaleye commented 6 years ago

I'd argue that handling strings and converting them to a strongly-typed interface belongs in the frontend - in the commandline parser stage for handling CLI args; in the config file loading stage for handling configurations, etc.

There will certainly be cases where people know they only want one of these, or they have a system based on numeric or UUID identifiers, or other reasons why the particular strings miscreant and/or xstream expect are irrelevant. In those situations, they will have lost static validation of what they're passing for zero gain.