search

misd-service-development / guzzle-bundle

[NOT MAINTAINED] Integrates Guzzle into your Symfony2 application
99 stars 54 forks source link

Can't install without SensioFrameworkExtraBundle #40

Closed thewilkybarkid closed 10 years ago

thewilkybarkid commented 10 years ago

Turns out #38 accidentally left the misd_guzzle.param_converter service in the services.xml file, containing a reference to the %misd_guzzle.param_converter.class% parameter. This isn't set if the SensioFrameworkExtraBundle isn't installed, leading to a ParameterNotFoundException.

The real version of the service is already correctly in param_converter.xml.

xabbuh commented 10 years ago

You're right. Will fix this tonight.

thewilkybarkid commented 10 years ago

I'll do it now and will tag a new version.

If the composer remove command from https://github.com/composer/composer/pull/2479 is implemented we can have a run without the SensioFrameworkExtraBundle being installed to make sure it's ok in the future (having tweaked the tests slightly).

xabbuh commented 10 years ago

Thanks for doing it!

thewilkybarkid commented 10 years ago

Just seen that ClientCompilerPass needs to know if it's installed too. Will fix that then be a bit naughty and retag.

thewilkybarkid commented 10 years ago

Fixed by 6eb157679a62aa07d2d165664e108c8ef73d3bc3