search

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
459 stars 143 forks source link

Automatically register the PhoneNumberType DBAL type #137

Closed fancyweb closed 4 years ago

fancyweb commented 7 years ago

Fixed ticket : https://github.com/misd-service-development/phone-number-bundle/issues/136

I had to require a higher version of the symfony/framework-bundle to get at least symfony/dependency-injection at version 2.2 because the PrependExtensionInterface interface only exists at this location since this version.

Also I set the commented option to false in the config because of a problem I discovered yesterday and that is related to the DoctrineBundle (cf https://github.com/doctrine/DoctrineBundle/issues/670). Basically keeping commtented to true (which is the default value) prevents the user from using the doctrine:database:create command. We don't really have to specify that the type is commented since the method requiresSQLCommentHint in the type class returns true.

shakaran commented 7 years ago

@rh389 This PR is interesting since fix a issue and allow new symfony recipes in Symfony 4.0, so it is important to merge if all is ok for you. The Travis CI failure is by hhvm config which could be updated with other PR which already has that

juliusstoerrle commented 6 years ago

Can we get an update on when this will be merged/ what has to be done before?

fancyweb commented 6 years ago

I can fix the conflict on the README whenever the maintainer of this bundle wants to merge my PR.