search

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
459 stars 143 forks source link

Make addViolation protected #143

Closed kathom-universe closed 6 years ago

shakaran commented 7 years ago

@rh389 This change seems suitable if you want extend or modify the validator, please check when you can for merge or decline, thanks!

shakaran commented 7 years ago

@rh389 BUMP ;)

robhogan commented 6 years ago

I'm not sure about encouraging subclassing PhoneNumberValidator. See also discussion at https://github.com/misd-service-development/phone-number-bundle/issues/19

What's the use case for this?

robhogan commented 6 years ago

Since we now use buildViolation when available I believe this is unnecessary