#158 - Changing the way it references twig templates

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application

459 stars 143 forks source link

#158 - Changing the way it references twig templates #159

Closed c0ntax closed 6 years ago

c0ntax commented 6 years ago

Well, this hasn't broken any tests, so I assume that this fix works. ;-)

giovkanata commented 6 years ago

@kosdfol there is something to do before merge this?

robhogan commented 6 years ago

I’ve lost touch with Symfony these days - can anyone point to docs / offer an explanation as to why this works? Is it backward compatible?

odolbeau commented 6 years ago

According to the documentation for symfony 3.4 here, using semi colons is the old syntax and is not recommended anymore. I guess it have been removed in sf4.

robhogan commented 6 years ago

Looks good, and the “new way” is documented back at least as far back as 2.7 so no BC issue. Merging! Thanks :)