search

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
459 stars 143 forks source link

Add support for bootstrap_4(_horizontal)_layout.html.twig #181

Open mathiasstocker opened 6 years ago

robhogan commented 6 years ago

Just looking very briefly I’m not sure what this code is originally for - did you work it out?

mathiasstocker commented 6 years ago

Symfony has built in form themes for Bootstrap 3 and newly added Bootstrap 4: https://symfony.com/doc/current/form/form_customization.html#what-are-form-themes

The phone number bundle worked when Bootstrap 3 form theme was activated but does not work with Bootstrap 4.

This pull request fixes this issue.

mathiasstocker commented 6 years ago

Also see #179

claire1604 commented 6 years ago

+1, need this fix

ruscon commented 6 years ago

+1

mathiasstocker commented 6 years ago

Until this is fixed you can use my fork: https://github.com/mathiasstocker/phone-number-bundle

@rh389 What about my pull request, is something not ok? Maybe you should disable tests on hhvm in Travis CI, seems there is no code coverage driver configured

kariae commented 5 years ago

any update about this PR?

effetb commented 5 years ago

Can we expect a solution for bootstrap 4 forms ? Is is still not working...

effetb commented 5 years ago

Hi, why about one year later this pull request is still not accepted ?

florianlemenach commented 5 years ago

@rh389 Hi, can you accept up this PR please ?

maxhelias commented 4 years ago

If you want, you can redirect your PR to this repo : https://github.com/odolbeau/phone-number-bundle We would be happy to merge this :)