search

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
459 stars 143 forks source link

Improve Travis configuration #184

Closed martin-georgiev closed 5 years ago

martin-georgiev commented 6 years ago
martin-georgiev commented 6 years ago

Looks that the Travis failure is irrelevant to the made changes. Can someone please retrigger the build on Travis?

JusteLeblanc commented 5 years ago

Looks that the Travis failure is irrelevant to the made changes. Can someone please retrigger the build on Travis?

@martin-georgiev Looks very nice! :)

You should exclude hhvm Symfony 4.* builds as Symfony ended HHVM support.

Same for PHP 5.3 builds as Github removed support for weak crypto standards, which are used in openssl version of PHP5.3.

martin-georgiev commented 5 years ago

@JusteLeblanc good call for HHVM + sf 4. However, I'd prefer to keep PHP 5.3 tested as long as the library officially supports it.