search

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
459 stars 143 forks source link

symfony/templating is a dependency #185

Closed Nek- closed 5 years ago

Nek- commented 6 years ago

This dependency was missing and generate failures on applications that does not require it.

xabbuh commented 6 years ago

What exactly requires the Templating component? Would it make more sense to replace that code with something else then?

Nek- commented 6 years ago

This class: https://github.com/misd-service-development/phone-number-bundle/blob/master/Templating/Helper/PhoneNumberHelper.php#L24

But well, maybe it should be removed from container if templating component not available?

robhogan commented 5 years ago

But well, maybe it should be removed from container if templating component not available?

Thanks for the PR but I think this is the better solution - will be addressed by https://github.com/misd-service-development/phone-number-bundle/pull/169