Symfony templating component required

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application

459 stars 143 forks source link

Symfony templating component required #203

Open Nek- opened 5 years ago

Nek- commented 5 years ago

The class PhoneNumberHelper which extends Symfony\Component\Templating\Helper\HelperInterface and is used in the context of a twig extension force the installation of symfony/templating.

Problem: Symfony templating is going to be deprecated (that's why the twig part does not require it anymore).

We should find a smooth solution to make work the bundle without the need of templating component. My first idea is to use a trait. WDYT ?

OskarStark commented 5 years ago

I have the same problem, requiring symfony/templating works but as you said... its deprecated

Nek- commented 5 years ago

@rh389 please tag it as help wanted if you accept my solution. cc @thewilkybarkid