search

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
459 stars 143 forks source link

PhoneNumberValidatorTest fails on CI #205

Open Nek- opened 5 years ago

Nek- commented 5 years ago

Why? Because the phone number +448431234567 is no more "shared cost" categorized.

How to fix?

  1. Remove the line 140
  2. Find a new share cost number (after a few google on the topic, can't find one)
maxhelias commented 5 years ago

You have also a error on this line for Sf < 3.0 : https://github.com/misd-service-development/phone-number-bundle/blob/master/Tests/Form/Type/PhoneNumberTypeTest.php#L224

But I think we can drop the support up to version 3.4