search

misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
459 stars 143 forks source link

Allow multiple type #208

Closed VincentLanglet closed 4 years ago

VincentLanglet commented 4 years ago 
new PhoneNumber('type' => [ 'fixed_line', 'mobile', 'voip']

and

@PhoneNumber(type={'fixed_line', 'voip'})

should be allowed syntax.

It fixed both https://github.com/misd-service-development/phone-number-bundle/issues/141, https://github.com/misd-service-development/phone-number-bundle/issues/142 or any multi-type use cases.

The PR wouldn't be hard, I can do it.

VincentLanglet commented 4 years ago

There is already an opened PR https://github.com/misd-service-development/phone-number-bundle/pull/191

VincentLanglet commented 4 years ago

This looks unmaintained