misd-service-development / phone-number-bundle

Integrates libphonenumber into your Symfony2-Symfony4 application
458 stars 143 forks source link

Add support for symfony 4.4 #216

Open cklm opened 5 years ago

cklm commented 5 years ago

Symfony 4.4 is released - its the long-term-supported version for the next years. Symfony 4.4 dropped support for some classes which makes the bundle unusable. Twig version 3 has now namespaces:

!!    #message: """
!!      Attempted to load class "Twig_Extension" from the global namespace.\n
!!      Did you forget a "use" statement?
!!      """
!!    #code: 0
!!    #file: "D:\projekte\tgh-sf\vendor\misd\phone-number-bundle\Twig\Extension\PhoneNumberHelperExtension.php"
!!    #line: 19
michaoj commented 5 years ago

I just fixed this error locally by changing the PhoneNumberHelperExtension

See attachment PhoneNumberHelperExtension.php.zip

maxhelias commented 5 years ago

This package has not been active for a while. You can block ths Twig 3 update in your project or find an alternative

maxhelias commented 5 years ago

Take a look here : https://github.com/odolbeau/phone-number-bundle