Exception handling - Githubissues

misd-service-development / raven-bundle

Adds Raven authentication to your Symfony2 application

1 stars 1 forks source link

Exception handling #4

Closed thewilkybarkid closed 11 years ago

thewilkybarkid commented 11 years ago

Some exceptions are uncaught, which result in 500 Internal Server Error pages. For example:

Clicking 'Cancel' on the Raven login page causes a RavenException.
Not having a user account causes a UsernameNotFoundException.

Possible configurable solutions include:

Setting a flash message and redirecting to an unsecured page.
Showing a 403 Forbidden page.

thewilkybarkid commented 11 years ago

After reviewing this, the bundle shouldn't catch these exceptions, they should be handled by listeners in the user's app. It should, however, throw more useful exceptions (eg AuthenticationCancelledException) which all extend RavenException.

It should also remove ?WLS-Response from the URL (ie do a redirect) so that refreshing the page doesn't try and use the failed Raven response.