search

miselin / mDNS-Unicast-Lookup

Provides responds to mDNS queries on a network by performing unicast DNS lookups.
ISC License
8 stars 1 forks source link

SRV record crashes proxy #4

Closed montehansen closed 7 years ago

montehansen commented 7 years ago

Upon loading the proxy, I witness it resolving A, AAAA, and PTR records. As soon as I try to authenticate via the kerberos protocol on an iOS device the proxy crashes processing an SRV record. Below is the output of that crash:

mDNS query from 172.XXX.XXX.XXX:5353
    for _kerberos._udp.NETWORK.LOCAL. [33]
Traceback (most recent call last):
  File "proxy.py", line 91, in <module>
    tmp = to_wire_helper()
NameError: name 'to_wire_helper' is not defined
M53081182:mDNS-Unicast-Lookup-master mhansen$

I am running python 2.7 on OS X 10.11.6

miselin commented 7 years ago

I can see the problem and will work on a patch. Thanks for the report!

miselin commented 7 years ago

I just pushed commit f323def2f320e6258d2aea816ef6031e0aa01ef8, which should resolve this problem.

montehansen commented 7 years ago

No, thank you for that commit! I tested it and it works.