search

misenhower / splatoon3.ink

🦑 Splatoon 3 map rotations, Salmon Run schedules, SplatNet gear, and more
https://splatoon3.ink
MIT License
225 stars 22 forks source link

[Bug] <GearCard> `font-family` missing `font-splatoon2`, display characters as '⎕' #19

Closed TenviLi closed 1 year ago

TenviLi commented 1 year ago

You can see this bug at https://splatoon3.ink/gear

image image

misenhower commented 1 year ago

Hey @TenviLi, I think the issue here is that your Chromium build is missing some fonts. I just tested generating screenshots for zh-CN and this text seems to show up correctly for me:

gear dailydrop

gear regular

Take a look at this line in my Dockerfile config. There might be some packages there you're missing.

TenviLi commented 1 year ago

Hey @TenviLi, I think the issue here is that your Chromium build is missing some fonts. I just tested generating screenshots for zh-CN and this text seems to show up correctly for me:

gear dailydrop

gear regular

Take a look at this line in my Dockerfile config. There might be some packages there you're missing.

Yes. This is the normal situation, missing fonts will be found from system built-in fonts. It would be bad if the user was running the environment without these system built-in fonts.

But the font-family is still wrong, does it is WenQuanYi Zen Hei(?), not the splatoon fonts.

catgirlinspace commented 1 year ago

But the font-family is still wrong, does it is WenQuanYi Zen Hei(?), not the splatoon fonts.

I think it being a more normal font makes a bit more sense here because of the small text. The Splatoon fonts are kinda hard to read at a small size.

This is also consistent with the font used by SplatNet 3 to display the remaining time.

TenviLi commented 1 year ago

I think it being a more normal font makes a bit more sense here because of the small text. The Splatoon fonts are kinda hard to read at a small size.

Well, I agree with you, readability also needs to be considered.