search

misfo / jim

Vim mode for Ace (Github & Cloud9's editor)
http://misfo.github.com/jim
MIT License
65 stars 3 forks source link

issues with Chrome 13 on x64 Fedora 14 #3

Closed misfo closed 13 years ago

misfo commented 13 years ago

Visual mode gives no visual feedback of where the selection is, even though regular Ace selections do.

Also, H, M, and L do not work either: https://github.com/misfo/jim/issues/2#issuecomment-1612678

michaelficarra commented 13 years ago

I actually don't ever see the visual mode selection, whether linewise or not. It still behaves properly, I just have no visual feedback. Again, Chrome 13 on x64 Fedora 14

misfo commented 13 years ago

Can you see selections when you make them in ace?: http://ajaxorg.github.com/ace/

michaelficarra commented 13 years ago

yes

misfo commented 13 years ago

Ok. I'll try to reproduce those issues and dig into what's going on. Thanks again for reporting

On Jul 16, 2011, at 9:50 PM, michaelficarrareply@reply.github.com wrote:

yes

Reply to this email directly or view it on GitHub: https://github.com/misfo/jim/issues/3#issuecomment-1588879

misfo commented 13 years ago

I wasn't able to reproduce the issues on Chrome 13 Ubuntu.

Since Ace draws the selections and you were able to see selections in the latest Ace, I updated the Ace submodule to the latest. Maybe that will fix the issue: http://misfo.github.com/jim/

If that doesn't fix it, can you try some selections again in Ace the idleFingers theme (what Jim uses) here: http://ajaxorg.github.com/ace/

michaelficarra commented 13 years ago

Selection works fine in Ace, even under the idleFingers theme. Selection using Jim does not work using v and V (by work, I mean I don't see it, but it behaves properly). I can, however, use my mouse to make selections and the escape key to clear them. But Jim doesn't behave as if these selections have been made, which is understandable.

misfo commented 13 years ago

So I've changed the visual mode movement to closer match what Ace keybindings do when moving the selection. Give that a shot. http://misfo.github.com/jim/

It's kind of a crap shoot trying to find the fix for this because I can't reproduce the problem. I know that some change selection rendering event isn't being fired correctly in your browser, but I can't really tell which one, so I'm going to have to try a bunch of little changes if you'll bear with me...

michaelficarra commented 13 years ago

Nope, sorry. Better luck next time.

I wish it was spitting out errors in the console or something so I could be of more help. Maybe add some (more) helpful logging? I get the setModes and @buffers if that helps...

misfo commented 13 years ago

This may be a bit hacky, but I pushed out a commit to gh-pages that just forces the event to fire after any visual mode motion. Let me know if that fixes it for you. Thanks http://misfo.github.com/jim/

michaelficarra commented 13 years ago

That one just made things worse. Now normal visual mode doesn't work properly and linewise visual mode breaks on the first use. I tried deleting three lines and it deleted everything until the end of the file. Also, still no visual feedback.

misfo commented 13 years ago

I'm sorry, man. But I'm gonna have to punt on these issues for now until I find a machine on which I can reproduce them. They're too hard to debug when I have to bug you each time I try a fix...

Because of the way linewise visual mode works in Vim (the cursor doesn't have to "stay" at either end of the selection) I may have to change how visual mode works anyways. If/when that happens I'll ping you to see if it improved the situation for you.

Thanks for testing all this stuff out for me. Let me know if the situation changes!

michaelficarra commented 13 years ago

Update: V works for the first line now, disappears once you move. v is still never visible.

misfo commented 13 years ago

@michaelficarra I pushed to gh-pages with a newer version of Ace that had some selection fixes. If you give that a try and it still doesn't work, I'll push a commit out with a bunch of relevant console.log's so we can get this figured out.

michaelficarra commented 13 years ago

Awesome! Just checked it out and it looks like selection is working perfectly now. Thanks.

edit: also, H, M, and L are working now

misfo commented 13 years ago

Good to hear!