search

mishagp / PauseInMultiplayer

A Stardew Valley mod that pauses time in multiplayer sessions when appropriate. 1.6 compatible!
13 stars 5 forks source link

Total mod overhaul for split-screen support #14

Open Xemrox opened 2 months ago

Xemrox commented 2 months ago

fixes all known split-screen bugs (#4) and releases as 1.9.0

mishagp commented 1 month ago

@Xemrox I'll review this week, thank you for the significant contribution!

Xemrox commented 1 month ago

hey thanks for the feedback. I didn't notice the regression as I am using it solely on local co-op and didn't use the old version much. What would be the expected behavior? Maybe I've fixed a bug without knowing. From what I can tell as soon as one of the players opens his menu the game pauses. In vanilla gameplay that happens only if both players open their menu.

Aside from that I've left a debug hotkey and a few verbose message changes in the mod which I like to remove first. On top of that after playing with the mod for quite a few hous (50+) I can relate to a user who requested to be able to toggle all features. So I'll propably work on this next #9 One bug though which is very hard to reproduce that I encountered is related to the skullcaverns and sometimes mines. From time to time on entering the mines the (second-only?) player HP gets reset (?) to 0/1 (can't tell the difference), which looks like some kind of unset variable. Gonna investigate that but no clue at the moment.