mishbahr / djangocms-instagram

A simple but versatile Instagram plugin for your django-cms powered sites.
https://pypi.python.org/pypi/djangocms-instagram/
BSD 3-Clause "New" or "Revised" License
22 stars 8 forks source link

Add some needed fields to template #9

Closed itcrab closed 7 years ago

itcrab commented 7 years ago

I added two fields to default user template:

itcrab commented 7 years ago

@mishbahr hi again) I add little functionality for more customizing

Please merge this PR

itcrab commented 7 years ago

@mishbahr ping

mishbahr commented 7 years ago

I'm not sure whether it's necessary to add those as fields.. especially media link text. That could be handled template level. Also you only added migration files for Shango. How about south migrations? While I'm happy to drop support for older version of django.. we need to update setup files to indicate that.

itcrab commented 7 years ago

@mishbahr please see my comments

I'm not sure whether it's necessary to add those as fields.. especially media link text. That could be handled template level.

In current PR general idea is add functionality to set any headline text and media link text in Django-CMS frontend editing plugin on page without any editing files "by hand". We add plugin on page and may edit this text in any time. If we don't needed this - we just don't set this text. Very simple.

Also you only added migration files for Shango. How about south migrations? While I'm happy to drop support for older version of django.. we need to update setup files to indicate that.

South is so oldest... I add all that needed for current Django release. If someone used oldest versions Django (when migrations was be only with South) - this problem will be fixed developer in new PR with new issue.

I like you don't have more time for solve all problems with oldest version packages. This PR fine works in current versions packages and it all for need us. You as main contributor may drop oldest versions packages and bump version for djangocms-instagram.

itcrab commented 7 years ago

@mishbahr ping