search

misheska / basebox-packer

Packer templates for vagrant baseboxes
286 stars 80 forks source link

Adding saltstack as a provisioner option #42

Closed howardroark closed 10 years ago

howardroark commented 10 years ago

As of now it is just for debian+ubuntu, centos+fedora

If you have interest in merging this in let me know and I will help clean it up to your preferences. I'd likely add it to some of the other distros over time as well :)

misheska commented 10 years ago

Merged in your code with a couple of changes (mostly in following the Google Shell Style Guide, per Ross Smith II in being a good idea - http://google-styleguide.googlecode.com/svn/trunk/shell.xml )

I'm not sure how to handle the defaults in the Makefile though with multiple providers. With Chef, it makes the most sense for a box to be "provisionerless" as one can use the vagrant-omnibus plugin to automatically download the Chef provisioner. Baking in a provisioner on the image is only really needed for Windows and some of the "fringe" OSes that vagrant-omnibus doesn't support. I'm not sure if there's an equivalent for SaltStack. So for now, I'm setting it to be provisionerless (which makes sense for the "no provisioner" and Chef for most of the OSes).

misheska commented 10 years ago

P.S. Thanks for your contribution - there are far too many templates now for me to be able to keep up with all of them, so happy to see others pitching in and helping out.

howardroark commented 10 years ago

No prob! This repo is a gold mine for me :P

As of now a salt gem is bundled with vagrant, it just runs the same bootstrap script used here if salt is not installed.

We make a tool that lets users bootstrap development stacks and salt is a must. We plan to bundle and offer boxes with salt preinstalled that we update as salt does.

Thanks for making this!