search

mishrsud / mvc-mini-profiler

Automatically exported from code.google.com/p/mvc-mini-profiler
0 stars 0 forks source link

Using mvc-mini-profiler monkey-patches array object #42

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I don't know if this is a bug per se, but I think there should maybe at least 
be a note about it somewhere. 

I noticed recently that some of my pages were breaking in IE. After a bit of 
sleuthing, I figured out that it's because mvc-mini-profiler uses less, which 
monkey patches the array prototype. Since I was iterating arrays using for (I 
know, I know...), this was causing problems.

Original issue reported on code.google.com by david.be...@gmail.com on 25 Jun 2011 at 12:02

GoogleCodeExporter commented 8 years ago 
yeah ... this is a bug ... we will fix .. patch more than welcome

Original comment by sam.saff...@gmail.com on 25 Jun 2011 at 6:13

GoogleCodeExporter commented 8 years ago 
My suggestion would be to switch to a less-compiled css file, and don't load 
less.js at all.
I had to do this in my own installation because the css wasn't loading I 
switched RouteBasePath to a subdirectory.
Plus why make everybody add new mime-types to their IIS config to load .less 
and .tmpl files?

Original comment by steve.wi...@gmail.com on 26 Jun 2011 at 5:18

GoogleCodeExporter commented 8 years ago 
I'll compile the .less -> .css in a pre-build step and embed that, removing the 
need for less.js.

Was meaning to do this for a while now :)

Original comment by jarrod.m.dixon on 27 Jun 2011 at 8:19

GoogleCodeExporter commented 8 years ago 
I've checked in a changeset that has static .css now, obviating the need for 
less.js.

We'll be pushing a new NuGet version this evening with these changes.

Original comment by jarrod.m.dixon on 28 Jun 2011 at 12:06