search

mishurov / linux_elan1200_touchpad

Workarounds for ELAN1200 touchpad in Linux
19 stars 5 forks source link

Commit c386f92 Breaks Functionality #5

Closed timschroederme closed 6 years ago

timschroederme commented 6 years ago

The latest commit c386f92 fixed the suspend issue but broke the overall functionality of the module for me. The module is loaded but does not fix anymore the random jumps and random right-click events during two-finger scrolling. I am using kernel 4.15.6.

mishurov commented 6 years ago

That's weird, I didn't change anything related directly to event reports. Only initialisation. I added timestamp and hdev constants.

mishurov commented 6 years ago

You may try to remove this line input_event(td->input, EV_MSC, MSC_TIMESTAMP, td->timestamp + 1);

And change hdev->quirks |= HID_QUIRK_NO_INPUT_SYNC; to hdev->quirks |= HID_QUIRK_NO_INIT_REPORTS;

As it was before the commit. If it helps, I'll make another commit.

mishurov commented 6 years ago

I amended the latest commit. I hope it helps.

timschroederme commented 6 years ago

Thanks. I think this fixes it for me. Will monitor it for a longer time and re-open if I see it again.