search

miskatonicstudio / intrepid

90 stars 8 forks source link

Convert music files to OGG Vorbis quality 8 #2

Open akien-mga opened 5 years ago

akien-mga commented 5 years ago

Using: ffmpeg -i sounds/<file>.wav -codec:a libvorbis -qscale:a 8 sounds/<file>.ogg

Also cleaned up used .import files.

Fixes #1.

I don't mind if you prefer to keep the WAV files and reject this PR, it is just a proposal.

miskatonicstudio commented 5 years ago

Sorry for not answering, GitHub didn't send any notifications about issues/PRs.

This is a very good idea, thank you very much! I'll try to test our PR locally and check if all the sounds work. If so, I don't see any reason not to merge it :) I don't think I will upload new versions of Intrepid to Steam/itch.io/company website (that would require a long testing process on all 3 platforms), but reducing the size of this repo might help other people who would like to use this code for their own projects.

Thank you very much for all the effort you've put into this PR :+1:

miskatonicstudio commented 5 years ago

I've just tested this PR and most of the sounds work perfectly! There is a problem with just one of them: exit_music_reverse.ogg. I couldn't hear it at all, even though the .ogg file itself is fine. Playing the sound in Godot editor also works. I'll have to take a closer look later.

miskatonicstudio commented 5 years ago

There is a scene: TestExitAnimation, which can be used to easily check this sound. I'm surprised that I've left some test scenes in the public repo, but they seem to be useful :)