search

miskatonicstudio / intrepid

90 stars 8 forks source link

Start Tween after configuring interpolation #3

Closed akien-mga closed 5 years ago

akien-mga commented 5 years ago

There was apparently a breaking change in Godot 3.1 (possibly godotengine/godot#19781) which means that Tween will now stop processing if it has nothing to do. So the previous code that pre-started Tween in _ready() would not work in Godot 3.1.

The new code seems to work for both Godot 3.0.6 and 3.1.1.

Note: I haven't done extensive testing yet, simply checked that the doors work in both 3.0.6 and 3.1.1. I haven't tested other tweens that this PR attempts to fix similarly.

miskatonicstudio commented 5 years ago

Sorry for not answering, GitHub didn't send any notifications about issues/PRs.

Yes, I've noticed that Tweens seem to work a bit differently in the new version of Godot. Amazing as they are, they seem to be full of bugs also in Godot 3.0 (e.g. some problems with sending tween_completed signal in a proper moment or with is_active method). The README mentions that the game was created using 3.0.6, and keeping the codebase up to date is not a priority right now (anyone who wants to use the code will have to probably modify it anyway). But I'll try to find the time and check this PR. If it's not too much work to test it, I would gladly merge it :)

Thanks for helping with the development of Intrepid :+1: I hoped that with the code released some people will start working on it, and it actually happened! :)