search

miskatonicstudio / intrepid

90 stars 8 forks source link

Upgrade Intrepid's codebase to use Godot 3.4.4 #7

Closed miskatonicstudio closed 2 years ago

miskatonicstudio commented 4 years ago

It seems that most things work, but there is a problem with reflections/specular.

Here is the original version (Godot 3.0.6): Screenshot from 2019-11-04 22-25-20

And here's after using the same codebase in Godot 3.1: Screenshot from 2019-11-04 22-26-16

Perhaps there is a new project setting that will take care of it. Otherwise, it's possible that all materials have to be updated manually.

miskatonicstudio commented 2 years ago

This problem was solved by fixing the bake mode in one of the lamps in this commit: abcea6fcfc7e9260781bc9ce94e6be93414d4bcc. Apparently, with the wrong bake mode the lamp was not working at all, generating no light and no reflections.

No other issues were found by far, so this concludes the migration of Intrepid to a newer version of Godot Engine (3.4.4 instead of the originally planned 3.1). If any other problems are found, then new GitHub issues can be created for them.

@akien-mga I think you were interested in this, so I'm just letting you know it's resolved :)