misl / openapi-validator-maven-plugin

Plugin to validate and merge splitted OpenAPI specification files.
6 stars 1 forks source link

threadsafe mojo? #44

Open jorgheymans opened 2 years ago

jorgheymans commented 2 years ago

Running this mojo in a multithreaded build gives the warning that it's not marked as @threadSafe . Can it be marked as such?

[WARNING] The following plugins are not marked @threadSafe in project:
12719 [WARNING] it.traeck.tools.openapi:openapi-validator-maven-plugin:1.0.2
12719 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
misl commented 2 years ago

Please note this plugin has not been updated in a long time.

Right now I can not think of any reason why @ThreadSafe would be an issue. Source are available so I'd say, give it a try.

jorgheymans commented 2 years ago

We are running it in a multithreaded build -T1C, and all seems ok. It's just the warning that is annoying. One would have to study the sources in detail i guess to be sure that the code is fully reentrant.

On Sat, Feb 19, 2022 at 12:14 PM Minto @.***> wrote:

Please note this plugin has not been updated in a long time.

Right now I can not think of any reason why @threadsafe https://github.com/threadsafe would be an issue. Source are available so I'd say, give it a try.

— Reply to this email directly, view it on GitHub https://github.com/misl/openapi-validator-maven-plugin/issues/44#issuecomment-1045993696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABPKABLDVLVTSLCVC44XMDU353R5ANCNFSM5OXNRZXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>