mislam / dotfiles

Beautify your bash terminal with awesome looking prompt.
40 stars 5 forks source link

Thank you for ruining my system. #4

Open nafaabout opened 8 years ago

nafaabout commented 8 years ago

The safe_copy function is not safe at all, I tell you why. I mistakenly run the install.sh script twice, what that script did is to copy the .bashrc and .vimrc files to their correspondent *.bak files. the second time I run the script, it did the same thing. so what I now have is the same copy of .bashrc in both .bashrc and .bashrc.bak as well as for .vimrc, and I lost the my original copy. Didn't you count for this scenario. at least you have to check if the .bak file exists already, and create a .bakx copy while x is a number. this way that function will be truly safe, no matter how many times I run that script of bullshit. Any way, thank you for messing up my system.

michaelahlers commented 8 years ago

Noticed this, too, when reviewing install.sh. Makes me wish for a “lite” version providing minimal instructions for modifying existent shell configurations.