miso-belica / sumy

Module for automatic summarization of text documents and HTML pages.
https://miso-belica.github.io/sumy/
Apache License 2.0
3.46k stars 525 forks source link

Adding Greek Language support for Sumy #167

Closed NC0DER closed 2 years ago

NC0DER commented 2 years ago

Greetings,

I am a PhD Candidate and Greek native speaker. I wish to add support for the Greek language in your library. Following the instructions of this section regarding the support of the new language, I implemented these steps. However, for the stemming of Greek words, I utilized this library, which is licensed under the LGPL-3 license. Practically speaking, this license mandates the inclusion of the LGPL-3 license, for the use of that library. I have searched online for other python implementations of Greek stemmers with a more permissive license but I haven't found anything else.

Would you be interested in me submitting a pull request, which adds Greek support but includes the LGPL-3 as a secondary license? Note that this license would apply only for the Greek stemmer part.

Thank you for your time.

miso-belica commented 2 years ago

Hi @NC0DER, thanks for the deep analysis. I believe you can include dependencies of any license (except maybe GPL and AGPL-like licenses) as long as the code is not included in sumy's repo directly. I also found similar Q&A with the same opinion at https://opensource.stackexchange.com/a/10571. I am really a lame when it comes to this stuff and always use sites like https://choosealicense.com/licenses/ and https://tldrlegal.com/ but if you you just point to the the optional LGPL library in setup.py file I believe it's fine and you don't even have to change the license here. It is a separate code. The library is even optional part (kind of language-support plugin) and even GPL is allowed to license code separately in the case of plugins.

Also, a lot of licenses apply only when you distribute the SW and that is not the case here. Even if someone would distribute the sumy code the LGPL part is a separate library that one has to download with the source opened and license included.

Support for the Greek language is welcome 🙂