misode / misode.github.io

Data Pack Generators and Tools for Minecraft 1.15, 1.16, 1.17, 1.18, 1.19, 1.20, 1.21
https://misode.github.io/
MIT License
491 stars 68 forks source link

Incorrect Application of Additional Field for Enchantment Entity Effect #530

Closed catter1 closed 3 weeks ago

catter1 commented 1 month ago

With custom enchantments, there is the entity effect spawn_particles. One of the fields, horizontal_position (or vertical_) has the types of entity_position or in_bounding_box.

According to the wiki, if in_bounding_box is used, there is an optional field of scale, to scale the bounding box. image

However, in the enchantment generator, scale appears when entity_position is selected, rather than in_bounding_box. This should be reversed (if the wiki is correct). image image

edit: In fact, the datapack actually fails to validate if the scale field is used alongside entity_position. I am testing in 1.21 pre-1. I glanced over the past couple of snapshot articles, but I didn't see any changes to this (in case if this was a case on the generator simply not being updated to the latest snapshot).